Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust types in storage module. #8798

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@toregge
Copy link
Member

toregge commented Mar 14, 2019

@baldersheim : please review

@toregge toregge requested a review from baldersheim Mar 14, 2019

<< "total" << elem.second.bucketsTotal()
<< "pending" << elem.second.bucketsPending()
<< "total" << static_cast<uint64_t>(elem.second.bucketsTotal())
<< "pending" << static_cast<uint64_t>(elem.second.bucketsPending())

This comment has been minimized.

Copy link
@baldersheim

baldersheim Mar 14, 2019

Member

Burde det bli brukt mer primitive typer i Json stream ?

Revert typecasting of variables sent to JsonStream, instead assume that
JsonStream will get overloads for the relevant fundamental types.

@baldersheim baldersheim merged commit 5965ad1 into master Mar 14, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details

@baldersheim baldersheim deleted the toregge/adjust-types-in-storage branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.