Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Protobuf over jrt support in search" #8807

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@baldersheim
Copy link
Member

baldersheim commented Mar 15, 2019

Reverts #8739
Do we need protobuf in container-disc ?
I guess container-search would be fine.
Let us not introduce any dependencies that are not needed.

@baldersheim baldersheim requested review from gjoranv, freva, bratseth and ollivir Mar 15, 2019

@freva

freva approved these changes Mar 15, 2019

@baldersheim baldersheim merged commit c27b4c3 into master Mar 15, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details

@baldersheim baldersheim deleted the revert-8739-ollivir/protobuf-search branch Mar 15, 2019

@ollivir

This comment has been minimized.

Copy link
Contributor

ollivir commented Mar 15, 2019

FWIW, it can’t be in container-search because it has to be the same in searchlib. Container-disc may be the nearest common ancestor (or not) in which case the problem may be that the dependency is materialised in searchlib. TBD.

@bratseth

This comment has been minimized.

Copy link
Member

bratseth commented Mar 15, 2019

This revert somehow broke searchlib_java on factory. But it works fine when I build and there are no logs on factory. Any ideas?

@bratseth

This comment has been minimized.

Copy link
Member

bratseth commented Mar 15, 2019

Nm, I found it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.