Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data store getBufferEntry() -> getEntry() and change it to tak... #8832

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@geirst
Copy link
Member

geirst commented Mar 19, 2019

…e entry ref as argument.

Also add getEntryArray() that is used when arraySize > 1 and the offset in entry ref is scaled accordingly.

@toregge please review

Rename data store getBufferEntry() -> getEntry() and change it to tak…
…e entry ref as argument.

Also add getEntryArray() that is used when arraySize > 1 and the offset in entry ref is scaled accordingly.

@geirst geirst requested a review from toregge Mar 19, 2019

@geirst geirst changed the title Rename data store getBufferEntry() -> getEntry() and change it to tak… Rename data store getBufferEntry() -> getEntry() and change it to tak... Mar 19, 2019

@geirst

This comment has been minimized.

Copy link
Member Author

geirst commented Mar 19, 2019

@toregge ping

@toregge
Copy link
Member

toregge left a comment

👍

@baldersheim baldersheim merged commit e5b87d5 into master Mar 19, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@baldersheim baldersheim deleted the geirst/more-datastore-refactoring branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.