Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gjoranv/metrics proxy container #8876

Merged
merged 12 commits into from Mar 26, 2019

Conversation

Projects
None yet
4 participants
@gjoranv
Copy link
Contributor

gjoranv commented Mar 22, 2019

This sets up a new 'metrics' container cluster, with one container on every node. But only in CD for now.

@gjoranv gjoranv requested review from bjorncs and hmusum Mar 22, 2019

@gjoranv gjoranv force-pushed the gjoranv/metrics-proxy-container branch from bd9eaf9 to 930757a Mar 22, 2019

@hmusum
Copy link
Contributor

hmusum left a comment

Does the orchestrator (policies) need to know about this new cluster and service type?

@gjoranv gjoranv force-pushed the gjoranv/metrics-proxy-container branch from b96be16 to 5846fc4 Mar 22, 2019

@gjoranv

This comment has been minimized.

Copy link
Contributor Author

gjoranv commented Mar 22, 2019

Created a feature flag. I assume that we can remove it after all hosted config models use a version that doesn't need the flag?

I'll add a unit test with the flag on Monday.

@hmusum

This comment has been minimized.

Copy link
Contributor

hmusum commented Mar 25, 2019

Yes, the flag can be removed as soon as no config model uses it

@gjoranv

This comment has been minimized.

Copy link
Contributor Author

gjoranv commented Mar 25, 2019

Ok, thanks. Will add a unit test, and then it should be ready to merge.

@gjoranv

This comment has been minimized.

Copy link
Contributor Author

gjoranv commented Mar 25, 2019

@hmusum PTAL

@hmusum

hmusum approved these changes Mar 26, 2019

@gjoranv gjoranv merged commit 516af39 into master Mar 26, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gjoranv gjoranv deleted the gjoranv/metrics-proxy-container branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.