Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using python script for cppunit tests #8900

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@arnej27959
Copy link
Contributor

commented Mar 26, 2019

@geirst please review and merge
@vekterli @baldersheim FYI

@geirst
Copy link
Member

left a comment

Overall looks good. One comment regarding valgrind we need to decide first

@@ -32,5 +32,6 @@ vespa_add_executable(storage_testrunner_app TEST

vespa_add_test(
NAME storage_testrunner_app
NO_VALGRIND

This comment has been minimized.

Copy link
@geirst

geirst Mar 26, 2019

Member

Was this intentional? Do we really want to run without valgrind? @baldersheim

This comment has been minimized.

Copy link
@arnej27959

arnej27959 Mar 26, 2019

Author Contributor

it was intentional - that test suite took a really long time with valgrind, moving to gtest will fix this also i guess...

This comment has been minimized.

Copy link
@vekterli

vekterli Mar 26, 2019

Member

I am not comfortable running storage tests without valgrind. How much of an impact does this really have compared to the rest of the build process?

This comment has been minimized.

Copy link
@geirst

geirst Mar 27, 2019

Member

Then I suggest we run storage tests with valgrind as before. @arnej27959 can you fix?

@aressem aressem changed the title stop using python script for cppunit tests stop using python script for cppunit tests Mar 27, 2019

@geirst

geirst approved these changes Mar 27, 2019

Copy link
Member

left a comment

👍

@arnej27959 arnej27959 changed the title stop using python script for cppunit tests stop using python script for cppunit tests Mar 29, 2019

@arnej27959 arnej27959 merged commit a748f74 into master Mar 29, 2019

3 checks passed

Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arnej27959 arnej27959 deleted the arnej/no-more-python branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.