Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt to get 2 GA trackers set up #1679

Merged
merged 3 commits into from Jan 10, 2019
Merged

Another attempt to get 2 GA trackers set up #1679

merged 3 commits into from Jan 10, 2019

Conversation

smcmurtry
Copy link
Collaborator

@smcmurtry smcmurtry commented Jan 9, 2019

Closes #1678

For some reason the solution is to add a name to one of the trackers but not the other?! Oh well it seems to work.

@sastels sastels temporarily deployed to vac-poc-pr-base-pr-1679 January 9, 2019 20:56 Inactive
@smcmurtry smcmurtry temporarily deployed to vac-poc-pr-base-pr-1679 January 9, 2019 20:58 Inactive
trackingId: process.env.GA_UA_CDS
}
]
// , { debug: true }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this in since it will be useful if we ever need to modify this file again

@smcmurtry smcmurtry changed the title [WIP] Another attempt to get 2 GA trackers set up Another attempt to get 2 GA trackers set up Jan 9, 2019
Copy link
Contributor

@SupeDeDupe SupeDeDupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🦑 👍

@smcmurtry smcmurtry merged commit e370961 into master Jan 10, 2019
@smcmurtry smcmurtry deleted the ga_take_2 branch January 10, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants