Add "Open File" Feature #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
added
PR-Needs-Review 🔍
vexx32
force-pushed
the
Feature/OpenFile
branch
2 times, most recently
from
a9198c6
to
dc4ba7f
Compare
- Move `-Meditate` to open the current file - Add `-Library` to open the folder.
When Get-PSKoan is called with the user scope it needs to check if the folder actually exists.
- Use temp dir in show-karma test - Restructure tests to avoid duplication
vexx32
force-pushed
the
Feature/OpenFile
branch
from
fa5c876
to
d44205d
Compare
steviecoaster
approved these changes
Jan 23, 2020
|
@steviecoaster yeah, PS ISE doesn't support a great deal of flexibility really, all it supports as far as I could find is a file path argument, much like most other editors will. We can always add new ones and reevaluate the solution as we go if we need to ^^ |
|
@vexx32 Hi Joel, sorry for the long delay, I've been super busy lately, and since I didn't have much experience with Pester I needed time to fix the tests. anyway, I'm happy you guys picked it up, I'm going to do the PSKoans test from the start and I'll let you know if I find any problem. 😊 |
|
@arefg not a problem! Hopefully everything works as expected! I'm looking to get this and other recent changes packed into a new release soon. 😊💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add functionality for opening current koan file instead of just the overall PSKoanLocation from
Show-KarmaContext
This PR supersedes #317, all credit for initial idea goes to @arefg -- thank you so much for the work you put in on this already, it really made this a hundred times easier. 😊 💖
Changes
-Libraryswitch.-Contemplateswitch to work as an "open current file in the set editor" with capability to recognisecodeandcode-insidersas well asatomand pass correct arguments for these editors to also go to the relevant line in the file.Checklist