Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some pester scoping issues and validation issues #388

Merged
merged 4 commits into from
May 19, 2020
Merged

fixed some pester scoping issues and validation issues #388

merged 4 commits into from
May 19, 2020

Conversation

udubnate
Copy link
Contributor

@udubnate udubnate commented May 14, 2020 •
edited by vexx32
Loading

PR Summary

Context

Goal is to improve functionality and clean up some pester related scoping issues

Changes

  • Fixed parenthesis issue for 2 pester tests
  • fixed pester scope issue
  • added line return to help clarity

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

vexx32
vexx32 requested changes May 14, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! There's one point we'll need to figure something else out for, but the rest look good. Nice work! 😊 💖

PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated Show resolved Hide resolved
@vexx32 vexx32 added the Category-Koans Invoking the Great Doubt label May 14, 2020
@vexx32 vexx32 added the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label May 19, 2020
vexx32
vexx32 approved these changes May 19, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much! 😊 💖

@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label May 19, 2020
@vexx32 vexx32 merged commit 1bb29d7 into vexx32:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasrayner thomasrayner thomasrayner requested changes

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udubnate @thomasrayner @vexx32