Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Koei Tecmo GC ADPCM (Switch) #623

Closed
DeathChaos25 opened this issue May 13, 2020 · 7 comments
Closed

[Request] Koei Tecmo GC ADPCM (Switch) #623

DeathChaos25 opened this issue May 13, 2020 · 7 comments

Comments

@DeathChaos25
Copy link

DeathChaos25 commented May 13, 2020

Koei Tecmo Switch games use GC ADPCM (such as Fire Emblem: Three Houses, Persona 5: Scramble, Marvel Ultimate Alliance 3, and so on), and while it is possible to make a txth with the needed information to play the files back, the files may contain padding (and are very pointer based) which means sometimes a lot of different .txth files are needed even from audio coming from the same container, as it involves pointer maths, so I am making a feature request for this format with the .ktgcadpcm extension to read these files.

Attached below are sample files (with working .txth) from Fire Emblem: Three Houses (base game), Three Houses DLC, and 2 different Persona 5 Scramble samples, ALL with a different .txth, as well as a 010 Editor Template we have made that can be used to get the relevant info I used to make all the sample .txth files included (just use the template on the included .vgmstream files), this means no research is needed into the format, just an implementation of the 010 Editor template.
Three Houses - Academy Ferdinand (base game).zip

Three Houses - Academy Balthus (DLC).zip

P5S - Morgana.zip

P5S - ActBossDemi SFX.zip

KTGCADPCM 010 Editor Template.zip

@bnnm
Copy link
Collaborator

bnnm commented May 16, 2020

You can actually use pointer tables with TXTH, kinda unwieldy though. This .txth works for all: vgmstream.txth.zip

Generally, mini-subfiles from sfx sound banks that don't exist externally aren't added, unless there is some good reason (made up extensions are no good, plus I feel TXTH gives enough tools to play around in those cases).

Instead, I'd rather add the original container, since that's what most people would try to open with vgmstream, without having to extract subfiles first. I take it's .ktsl2stbin w/ KTSR, so you could upload samples for that instead. KTSR with other codecs is also used in other platforms (I have samples for those).

@DeathChaos25
Copy link
Author

I don't mind uploading samples for the KTSR files instead, although those can get weird since they contain more than just the sound (they also tend to contain data for external audio files?).

2 Samples from Three Houses (Base Game + DLC), and a random assortment of samples from P5 Scramble that I have no idea where they belong due to the game being JP only at the moment. Usually, KTSR files are found with the .ktsl2asbin file extension (where filenames exist), there's also weird cases like P5S where the KTSR file is in a .srsa """wrapper""" (literally 0x10 bytes of useless data because KTSR itself already has filesize data).

Three Houses - Byleth (Female).zip
Three Houses - Hapi (DLC).zip
P5S KTSR Samples.zip

@bnnm
Copy link
Collaborator

bnnm commented May 24, 2020

Works now. https://ci.appveyor.com/project/kode54/vgmstream/branch/master/artifacts

I didn't add the .srsa wrapper since it looks like some generic thing not really related to the KTSR.

Probably needs support for .ktsl2asbin+.ktsl2stbin w/ KTSS, post if you find some.

@Mysticus92
Copy link

For Atelier Ryza, the voices files still doesn't work for some reason.
Do you plan to fix it?

@bnnm
Copy link
Collaborator

bnnm commented Jul 8, 2020

I don't have those files so you'd need to post samples.

@Mysticus92
Copy link

@bnnm
Copy link
Collaborator

bnnm commented Jul 12, 2020

Those work now.

@bnnm bnnm closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants