Log a warning when parsing of the config file has failed #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
suggested changes
Feb 13, 2018
src/SSEConfig.cpp
Outdated
| @@ -70,7 +70,9 @@ bool SSEConfig::load(const char *file) { | |||
| // Read config file. | |||
| try { | |||
| boost::property_tree::read_json(file, pt); | |||
| } catch (...) {} | |||
| } catch (boost::property_tree::ptree_error& e) { | |||
| LOG(WARNING) << "Error during loading config file: " << e.what(); | |||
There was a problem hiding this comment.
Perhaps log FATAL instead of WARNING? It shouldn't be able to start up at all without a proper config.
There was a problem hiding this comment.
Thanks for noticing, this is absolutely a check we should have. I agree with @sgulseth regarding that it should be a FATAL and not a warning. Add in that and I will merge the PR!
There was a problem hiding this comment.
Ok, I've changed it to FATAL and now the app doesn't start when config is not parsed or not present. Thanks for your feedback.
sgulseth
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour is counterintuitive. The config is silently ignored without any message when there is JSON parse error.
So I added a warning, but one can still omit the config file to use the default configuration.