Improve auto unmount #293
Improve auto unmount #293
Conversation
encfs/main.cpp
Outdated
| if (access("/bin/umount", F_OK) != -1) | ||
| rc = system(("/bin/umount "+std::string(arg->opts->mountPoint)).c_str()); | ||
| else | ||
| rc = system(("/sbin/umount "+std::string(arg->opts->mountPoint)).c_str()); |
There was a problem hiding this comment.
I wonder if it's worth it to search $PATH if mount is not found in the "normal" locations.
Also, how would this port to Windows, Mac OS, or FreeBSD?
There was a problem hiding this comment.
Thank you for your review Sam !
The risk of searching through $PATH is to run a malicious umount, this is why I used only hard-coded paths.
FreeBSD :
# which umount
/sbin/umount
Mac OS :
# which umount
/sbin/umount
Do you have some systems in mind with umount elsewhere ?
Regarding Windows, good question.
Seems that encfs4win calls fuse_unmount but disables fuse_unmount_compat22, as this fuse_unmount call goes to Dokany library.
There was a problem hiding this comment.
- we can't call
fuse_unmountas we don't have a fuse handle (fuse_maindoes not return it) ;
Well, according to encfs4win call to fuse_unmount (second parameter to NULL), and according to libfuse source code, we could clearly set this second parameter to NULL.
Let me do some tests, however I think I will still face the drawbacks listed in the first post.
There was a problem hiding this comment.
I notice encfs4win is a complete fork. Is encfs not designed to run on Windows as well? I guess not since it requires a whole fork.
|
So here is a fuse-only method, which is then Windows compatible. |
|
Cool :-) looks good to me. I'll let someone with more seasoned eyes than mine do the final approval and merge. |
|
Thank you very much Sam 👍 |
|
Hi @rfjakob ! |
|
Let's go. |
|
Thank you ! |
Hello,
Here is a PR to improve auto unmount.
It does not use
fuse_unmount_compat22anymore, which :Thank you 👍
Ben