From d9e8ab9f41a6c8d7371aa07bcc49d85db8e605c5 Mon Sep 17 00:00:00 2001 From: Ethan Rodkin Date: Fri, 15 Mar 2024 08:51:46 -0400 Subject: [PATCH] get rid of override=0 pattern --- src/viam/sdk/components/base.hpp | 9 --------- src/viam/sdk/components/motor.hpp | 9 --------- src/viam/sdk/components/servo.hpp | 9 --------- 3 files changed, 27 deletions(-) diff --git a/src/viam/sdk/components/base.hpp b/src/viam/sdk/components/base.hpp index a776f00fe..569e8fbde 100644 --- a/src/viam/sdk/components/base.hpp +++ b/src/viam/sdk/components/base.hpp @@ -102,15 +102,6 @@ class Base : public Component, public Stoppable { const Vector3& angular, const AttributeMap& extra) = 0; - /// @brief Stops a robot's base - inline void stop() { - return stop({}); - } - - /// @brief Stops a robot's base - /// @param extra Any additional arguments to the method - virtual void stop(const AttributeMap& extra) override = 0; - /// @brief Reports if the base is in motion virtual bool is_moving() = 0; diff --git a/src/viam/sdk/components/motor.hpp b/src/viam/sdk/components/motor.hpp index a4794e908..725df16b0 100644 --- a/src/viam/sdk/components/motor.hpp +++ b/src/viam/sdk/components/motor.hpp @@ -163,15 +163,6 @@ class Motor : public Component, public Stoppable { /// @brief Reports if a component is in motion virtual bool is_moving() = 0; - /// @brief Stops a resource from running. - inline void stop() { - return stop({}); - } - - /// @brief Stops a resource from running. - /// @param extra Extra arguments to pass to the resource's `stop` method. - void stop(const AttributeMap& extra) override = 0; - /// @brief Send/receive arbitrary commands to the resource. /// @param Command the command to execute. /// @return The result of the executed command. diff --git a/src/viam/sdk/components/servo.hpp b/src/viam/sdk/components/servo.hpp index 7b2f221be..277fc5715 100644 --- a/src/viam/sdk/components/servo.hpp +++ b/src/viam/sdk/components/servo.hpp @@ -53,15 +53,6 @@ class Servo : public Component, public Stoppable { /// @throws `Exception` if position reporting is not supported virtual position get_position(const AttributeMap& extra) = 0; - /// @brief Stops a resource from running. - inline void stop() { - return stop({}); - } - - /// @brief Stops a resource from running. - /// @param extra Extra arguments to pass to the resource's `stop` method. - void stop(const AttributeMap& extra) override = 0; - /// @brief Reports if a component is in motion virtual bool is_moving() = 0;