From ddab038875da176824e68c26fb324ef93b8dad5a Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:01:45 -0500 Subject: [PATCH 1/6] use bookworm for tests --- .github/workflows/test.yml | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 405a44667..863c733f4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,8 @@ jobs: test_ubuntu: if: github.repository_owner == 'viamrobotics' runs-on: ubuntu-latest - container: ghcr.io/viamrobotics/cpp-base:bullseye-amd64 + container: + image: debian:bookworm strategy: fail-fast: false matrix: @@ -24,6 +25,37 @@ jobs: - BUILD_SHARED: OFF steps: - uses: actions/checkout@v4 + + - name: Install dependencies + run: | + apt-get update + apt-get -y dist-upgrade + DEBIAN_FRONTEND=noninteractive apt-get -y --no-install-recommends install \ + build-essential \ + ca-certificates \ + cmake \ + curl \ + doxygen \ + g++ \ + gdb \ + git \ + gnupg \ + gpg \ + less \ + libboost-all-dev \ + libc-ares-dev \ + libgrpc++-dev \ + libprotobuf-dev \ + libre2-dev \ + libssl-dev \ + ninja-build \ + pkg-config \ + protobuf-compiler-grpc \ + software-properties-common \ + sudo \ + wget \ + zlib1g-dev + - name: cmake run: | mkdir build @@ -35,13 +67,16 @@ jobs: -DVIAMCPPSDK_BUILD_EXAMPLES=ON \ -DVIAMCPPSDK_CLANG_TIDY=${{ inputs.no-tidy && 'OFF' || 'ON' }} \ -DVIAMCPPSDK_SANITIZED_BUILD=${{ matrix.BUILD_SHARED }} + - name: build run: | cmake --build build --target install cmake --install build + - name: test working-directory: build run: ../etc/docker/tests/run_test.sh + test_windows: if: github.repository_owner == 'viamrobotics' runs-on: windows-latest From 5dcb9dc67d77680068f243cf49155303f0d23091 Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:02:33 -0500 Subject: [PATCH 2/6] remove bullseye from release matrix --- .github/workflows/release.yml | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bbb74cb39..398d1bf1e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -230,14 +230,6 @@ jobs: fail-fast: false matrix: include: - - target: aarch64-debian-bullseye - platform: linux_aarch64-debian-bullseye - image: debian:bullseye - runs_on: buildjet-8vcpu-ubuntu-2204-arm - - target: x86_64-debian-bullseye - platform: linux_x86_64-debian-bullseye - image: debian:bullseye - runs_on: buildjet-8vcpu-ubuntu-2204 - target: aarch64-debian-bookworm platform: linux_aarch64-debian-bookworm image: debian:bookworm @@ -283,17 +275,6 @@ jobs: wget \ zlib1g-dev - - name: Update CMake for bullseye - if: ${{ matrix.image == 'debian:bullseye' }} - run: | - sudo apt-get install -y software-properties-common - apt-add-repository -y 'deb https://archive.debian.org/debian bullseye-backports main' - - apt-get update - apt-get -y install cmake - - apt-get -y --no-install-recommends install -t bullseye-backports cmake - - name: Setup build directory run: mkdir builds From 2846e67040e8c79f7d2795c2aebd1c53ec64dd34 Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:06:26 -0500 Subject: [PATCH 3/6] touch file to trigger build --- .github/workflows/conan.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/conan.yml b/.github/workflows/conan.yml index 3163ead37..023844d6e 100644 --- a/.github/workflows/conan.yml +++ b/.github/workflows/conan.yml @@ -1,5 +1,6 @@ name: Test conan packages +# Temp on: # Runs for PRs that directly change conan code, and weekdays at 11:15pm UTC. # Additional logic in the prepare job below makes it so scheduled builds only run From 122742085c1ef7b7a3d2ab71683802e1bc976b98 Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:33:42 -0500 Subject: [PATCH 4/6] revert --- .github/workflows/conan.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/conan.yml b/.github/workflows/conan.yml index 023844d6e..3163ead37 100644 --- a/.github/workflows/conan.yml +++ b/.github/workflows/conan.yml @@ -1,6 +1,5 @@ name: Test conan packages -# Temp on: # Runs for PRs that directly change conan code, and weekdays at 11:15pm UTC. # Additional logic in the prepare job below makes it so scheduled builds only run From 61d14c428d0c8f2b565b07e786de483e34a21417 Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:37:53 -0500 Subject: [PATCH 5/6] add clang tidy --- .github/workflows/test.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 863c733f4..0fe579e09 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -56,6 +56,16 @@ jobs: wget \ zlib1g-dev + bash -c 'wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|apt-key add -' + apt-add-repository -y 'deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-15 main' + apt-get update + DEBIAN_FRONTEND=noninteractive apt-get -y --no-install-recommends install -t llvm-toolchain-bookworm-15 \ + clang-15 \ + clang-tidy-15 \ + clang-format + + + - name: cmake run: | mkdir build From 8d421e316abe658e91899d69ca2fdbfeb8a7aaae Mon Sep 17 00:00:00 2001 From: Lia Stratopoulos <167905060+lia-viam@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:39:49 -0500 Subject: [PATCH 6/6] duplicate --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0fe579e09..11ae53b66 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -58,6 +58,7 @@ jobs: bash -c 'wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|apt-key add -' apt-add-repository -y 'deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-15 main' + apt-add-repository -y 'deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-15 main' apt-get update DEBIAN_FRONTEND=noninteractive apt-get -y --no-install-recommends install -t llvm-toolchain-bookworm-15 \ clang-15 \