-
Notifications
You must be signed in to change notification settings - Fork 27
[RSDK-12691] NO_MODULE_PARENT #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lia-viam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be fine except for a linter warning in the build, you may be able to mark it with a // NOLINT(name-of-warning) comment
Co-authored-by: lia <167905060+lia-viam@users.noreply.github.com>
lia-viam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, wondering if this is currently possible for us to validate with manual testing though?
|
@lia-viam i did validate with manual testing! |
Allow the module to start without a module parent so that viam can detect modules without spinning up an RDK instance