Skip to content

Conversation

@njooma
Copy link
Member

@njooma njooma commented Nov 25, 2025

Allow the module to start without a module parent so that viam can detect modules without spinning up an RDK instance

@njooma njooma requested a review from gmulz November 25, 2025 20:16
@njooma njooma requested a review from a team as a code owner November 25, 2025 20:16
@njooma njooma requested review from lia-viam and stuqdog and removed request for a team November 25, 2025 20:16
Copy link
Collaborator

@lia-viam lia-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be fine except for a linter warning in the build, you may be able to mark it with a // NOLINT(name-of-warning) comment

njooma and others added 4 commits December 1, 2025 12:04
Co-authored-by: lia <167905060+lia-viam@users.noreply.github.com>
@njooma njooma requested a review from lia-viam December 1, 2025 20:23
Copy link
Collaborator

@lia-viam lia-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wondering if this is currently possible for us to validate with manual testing though?

@njooma
Copy link
Member Author

njooma commented Dec 1, 2025

@lia-viam i did validate with manual testing!

> viam module update-models --binary /Users/naveed/Developer/viam-cpp-sdk/build/src/viam/examples/modules/simple/simple_module --module meta.json

2025-11-25T19:36:59.051Z	INFO	x.modmanager.xxxx	modmanager/manager.go:268	Now adding module	{"module":"xxxx"}
2025-11-25T19:36:59.055Z	INFO	x.modmanager.xxxx	modmanager/module.go:294	Starting up module	{"module":"xxxx","tcp_mode":false}
2025-11-25T19:36:59.055Z	INFO	x.modmanager.xxxx	utils/env.go:179	Starting module with following Viam environment variables	{"environment":["VIAM_NO_MODULE_PARENT=true","VIAM_HOME=","VIAM_MODULE_DATA=","VIAM_MODULE_NAME=xxxx"]}
2025-11-25T19:36:59.428Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ 2025--11--25 13:36:59: [Viam C++ SDK] <info> [simple/main.cpp:87] Starting up simple sensor module
2025-11-25T19:36:59.434Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ 2025--11--25 13:36:59: [Viam C++ SDK] <info> [module/service.cpp:311] Module listening on /var/folders/kb/_9lx_66d2gjg_hydb9xp91z40000gn/T/viam-cli-test-2474802933/xxxx-ftGlv.sock
2025-11-25T19:36:59.435Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ 2025--11--25 13:36:59: [Viam C++ SDK] <info> [module/service.cpp:312] Module handles the following API/model pairs:
2025-11-25T19:36:59.435Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ API: rdk:component:sensor
2025-11-25T19:36:59.435Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ 	Model: viam:sensor:mysensor
2025-11-25T19:36:59.463Z	INFO	x.modmanager.xxxx	modmanager/module.go:116	Waiting for module to respond to ready request	{"module":"xxxx"}
2025-11-25T19:36:59.470Z	WARN	x.modmanager.xxxx	modmanager/module.go:181	Unable to create PeerConnection with module. Ignoring.	{"err":"unexpected end of JSON input"}
2025-11-25T19:36:59.473Z	INFO	x.modmanager.xxxx	modmanager/module.go:389	Registering component API and model from module	{"module":"xxxx","API":"rdk:component:sensor","model":"viam:sensor:mysensor"}
2025-11-25T19:36:59.473Z	INFO	x.modmanager.xxxx	modmanager/manager.go:389	Module successfully added	{"module":"xxxx"}
2025-11-25T19:36:59.473Z	INFO	x.modmanager	modmanager/manager.go:285	Modules successfully added	{"modules":["xxxx"]}
2025-11-25T19:36:59.473Z	INFO	x.modmanager.xxxx	modmanager/module.go:335	Stopping module: xxxx process
2025-11-25T19:36:59.473Z	INFO	x.modmanager.xxxx.xxxx	pexec/managed_process_unix.go:100	stopping process 70356 with signal terminated
2025-11-25T19:36:59.473Z	INFO	x.modmanager.xxxx.StdOut	pexec/managed_process.go:444	
\_ 2025--11--25 13:36:59: [Viam C++ SDK] <info> [module/service.cpp:292] Shutting down gracefully.
2025-11-25T19:36:59.477Z	INFO	x.modmanager.xxxx	modmanager/manager.go:523	Module successfully closed	{"module":"xxxx"}

@njooma njooma merged commit b12dfe3 into viamrobotics:main Dec 1, 2025
5 checks passed
@njooma njooma deleted the RSDK-12691/no-module-parent branch December 1, 2025 22:08
@lia-viam lia-viam mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants