Skip to content

[RSDK-12691] NO_MODULE_PARENT #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njooma merged 6 commits into from
Dec 1, 2025
Merged

[RSDK-12691] NO_MODULE_PARENT #510

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbb50a4
Read no module parent env var
njooma Nov 25, 2025
141707f
clang-format
njooma Nov 26, 2025
c9e9507
Update src/viam/sdk/module/service.cpp
njooma Dec 1, 2025
3f84e71
Add nolint
njooma Dec 1, 2025
4fa5c78
Fix lint
njooma Dec 1, 2025
bd89d5c
Had a double get env
njooma Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/viam/sdk/module/service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,15 +208,21 @@ struct ModuleService::ServiceImpl : viam::module::v1::ModuleService::Service {
const std::lock_guard<std::mutex> lock(parent.lock_);
const viam::module::v1::HandlerMap hm = to_proto(parent.module_->handles());
*response->mutable_handlermap() = hm;
auto new_parent_addr = parent.grpc_conn_protocol_ + request->parent_address();
if (parent.parent_addr_ != new_parent_addr) {
parent.parent_addr_ = std::move(new_parent_addr);
Options opts{0, boost::none};
opts.set_check_every_interval(std::chrono::seconds{5})
.set_reconnect_every_interval(std::chrono::seconds{1});
parent.parent_ = RobotClient::at_local_socket(parent.parent_addr_, opts);
parent.parent_->connect_logging();

const char* no_module_parent =
std::getenv("VIAM_NO_MODULE_PARENT"); // NOLINT(concurrency-mt-unsafe)
if (strcmp(no_module_parent, "true") != 0) {
auto new_parent_addr = parent.grpc_conn_protocol_ + request->parent_address();
if (parent.parent_addr_ != new_parent_addr) {
parent.parent_addr_ = std::move(new_parent_addr);
Options opts{0, boost::none};
opts.set_check_every_interval(std::chrono::seconds{5})
.set_reconnect_every_interval(std::chrono::seconds{1});
parent.parent_ = RobotClient::at_local_socket(parent.parent_addr_, opts);
parent.parent_->connect_logging();
}
}

response->set_ready(parent.module_->ready());
return grpc::Status();
}
Expand Down