New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST client doesn't support (typesafe) variadic arguments #1144

Closed
s-ludwig opened this Issue Jun 16, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Jun 16, 2015

The current implementation uses ParameterTuple to define the parameters of the overridden function. However, ParameterTuple doesn't contain the ellipses part of the last parameter (e.g. void foo(string[] bar...)) and thus the generated method doesn't override the corresponding one in the interface. This used to work in earlier versions where the parameter declaration was done using a string mixin.

@s-ludwig s-ludwig added the bug label Jun 16, 2015

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Jun 17, 2015

Contributor

Out of interest, what's the use case for this ? Is it relatd to http://forum.rejectedsoftware.com/groups/rejectedsoftware.vibed/thread/25596/ ?

Contributor

Geod24 commented Jun 17, 2015

Out of interest, what's the use case for this ? Is it relatd to http://forum.rejectedsoftware.com/groups/rejectedsoftware.vibed/thread/25596/ ?

Geod24 added a commit to Geod24/vibe.d that referenced this issue Jun 28, 2015

s-ludwig added a commit that referenced this issue Jun 29, 2015

Merge pull request #1159 from Geod24/fix-1144
[REST] Fix issue #1144 : Support variadic typesafe arguments
@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Jun 29, 2015

Contributor

Can be closed.

Contributor

Geod24 commented Jun 29, 2015

Can be closed.

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Jul 8, 2015

Contributor

Ping @s-ludwig

Contributor

Geod24 commented Jul 8, 2015

Ping @s-ludwig

@s-ludwig s-ludwig closed this Jul 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment