New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing Empty Headers #1254

Closed
skoppe opened this Issue Sep 10, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@skoppe
Contributor

skoppe commented Sep 10, 2015

In the parseRFC5322Header function in vibe/inet/message, empty headers are not allowed. Worse, it asserts whenever it finds one.

This is an issue because:

  • there are servers out there that respond with empty headers (the EXT header in the case of minidlna)
  • programs should be strict in what they output, and liberal in what they accept
  • I don't understand why vibe.d uses rfc 5322 to parse http headers, rfc 5322 is meant for email wikipedia
  • vibe.d should implement rfc 2616 or the newer rfc 7230 which allow empty headers

@s-ludwig s-ludwig closed this in 8febd2c Sep 11, 2015

@skoppe

This comment has been minimized.

Show comment
Hide comment
@skoppe

skoppe Sep 11, 2015

Contributor

Thanks for the quick fix.

Contributor

skoppe commented Sep 11, 2015

Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment