New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@safe-ty for vibe.core.stream #1595

Closed
Abscissa opened this Issue Oct 15, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@Abscissa

Abscissa commented Oct 15, 2016

If vibe.core.stream can be given the @safe/@trusted treratment, then mysql-native (or anything else that uses vibe streams) can start doing @safe too. Phobos's sockets seem to be @safe-compatible as of 2.067.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 10, 2016

Member

I'm currently in the process of @safetifying almost everything to be able to swap out vibe:core for vibe-core (which already defines the streams as @safe). The viral nature of @safe makes this a large change, but it will be in the next version (0.8.0). Unfortunately there are still lots of Phobos functions that are @system, so that littering the code with () @trusted { ... } () is necessary.

Member

s-ludwig commented Nov 10, 2016

I'm currently in the process of @safetifying almost everything to be able to swap out vibe:core for vibe-core (which already defines the streams as @safe). The viral nature of @safe makes this a large change, but it will be in the next version (0.8.0). Unfortunately there are still lots of Phobos functions that are @system, so that littering the code with () @trusted { ... } () is necessary.

@s-ludwig s-ludwig added this to the 0.8.0 milestone Nov 10, 2016

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 5, 2017

Member

Implemented by #1618.

Member

s-ludwig commented Jul 5, 2017

Implemented by #1618.

@s-ludwig s-ludwig closed this Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment