New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP concurrent read/write not properly terminated if peer closes connection #1726

Closed
s-ludwig opened this Issue Mar 28, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Mar 28, 2017

Most likely the cause for #1724. This happens for the libevent and libasync drivers, not for vibe-core.

@s-ludwig s-ludwig added the bug label Mar 28, 2017

s-ludwig added a commit that referenced this issue Mar 28, 2017

s-ludwig added a commit that referenced this issue Mar 28, 2017

Fix libevent socket event handler.
Now always resumes the writer if one is active. Partially resolves issue #1726.

s-ludwig added a commit that referenced this issue Mar 28, 2017

@tchaloupka

This comment has been minimized.

Show comment
Hide comment
@tchaloupka

tchaloupka Mar 28, 2017

Contributor

Might be related also to #1229

Contributor

tchaloupka commented Mar 28, 2017

Might be related also to #1229

s-ludwig added a commit that referenced this issue Mar 28, 2017

s-ludwig added a commit that referenced this issue Mar 28, 2017

Fix libevent socket event handler.
Now always resumes the writer if one is active. Partially resolves issue #1726.

s-ludwig added a commit that referenced this issue Mar 28, 2017

s-ludwig added a commit that referenced this issue Mar 28, 2017

s-ludwig added a commit that referenced this issue Mar 28, 2017

Fix libevent socket event handler.
Now always resumes the writer if one is active. Partially resolves issue #1726.

s-ludwig added a commit that referenced this issue Mar 28, 2017

@s-ludwig s-ludwig closed this in #1727 Mar 29, 2017

s-ludwig added a commit that referenced this issue Mar 29, 2017

Merge pull request #1727 from rejectedsoftware/issue_1726_tcp_close
Fix TCP close behavior in case of cuncurrent read+write operations. Fixes #1726.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 29, 2017

Member

@tchaloupka I think #1229 is something else. It seems to be something specific to the OpenSSL stream implementation. I'll have to try and reproduce it on a Windows machine to be able to say more.

Member

s-ludwig commented Mar 29, 2017

@tchaloupka I think #1229 is something else. It seems to be something specific to the OpenSSL stream implementation. I'll have to try and reproduce it on a Windows machine to be able to say more.

s-ludwig added a commit that referenced this issue Apr 7, 2017

s-ludwig added a commit that referenced this issue Apr 10, 2017

Merge pull request #1727 from rejectedsoftware/issue_1726_tcp_close
Fix TCP close behavior in case of cuncurrent read+write operations. Fixes #1726.
(cherry picked from commit 7479a8b)

# Conflicts:
#	source/vibe/core/drivers/libasync.d

s-ludwig added a commit that referenced this issue Apr 10, 2017

s-ludwig added a commit to vibe-d/vibe-core that referenced this issue May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment