New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL.toString messed up for tcp #1732

Closed
John-Colvin opened this Issue Apr 6, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@John-Colvin
Contributor

John-Colvin commented Apr 6, 2017

auto url = URL("tcp://0.0.0.0:1234");
url.port = 4321;
assert(url.toString == "tcp://0.0.0.0:4321", url.toString);

prints tcp::4321//0.0.0.0:1234

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Apr 7, 2017

Member

It seems like the "//" logic should have been reversed from the start. Almost all URL schemas have adapted the "//" style.

Member

s-ludwig commented Apr 7, 2017

It seems like the "//" logic should have been reversed from the start. Almost all URL schemas have adapted the "//" style.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig
Member

s-ludwig commented Apr 7, 2017

PR: #1733

@s-ludwig s-ludwig closed this in a5e5743 Apr 26, 2017

s-ludwig added a commit that referenced this issue Apr 26, 2017

Merge pull request #1733 from rejectedsoftware/issue_1732_tcp_urls
Refactor URL schema style detection and fix tcp:// URLs. Fixes #1732.

s-ludwig added a commit that referenced this issue Sep 2, 2017

Merge pull request #1733 from rejectedsoftware/issue_1732_tcp_urls
Refactor URL schema style detection and fix tcp:// URLs. Fixes #1732.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment