New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid StreamOutputRange in the WebSocket send implementation #1791

Closed
s-ludwig opened this Issue Jun 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@s-ludwig
Member

s-ludwig commented Jun 26, 2017

This causes an additional write() call on the underlying connection stream (which could be a TLS stream) for large frame payloads (starting from ~252 bytes). Since OutgoingWebSocketMessage already uses an Appender to accumulate payload data, it could easily reserve a few bytes for the header, so that the full frame could be sent in one go.

Original discussion: https://forum.rejectedsoftware.com/groups/rejectedsoftware.vibed/thread/43534/

s-ludwig added a commit that referenced this issue Jun 26, 2017

s-ludwig added a commit that referenced this issue Jul 7, 2017

s-ludwig added a commit that referenced this issue Jul 11, 2017

@dlang-bot dlang-bot closed this in #1792 Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment