New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script tag in diet doesn't allow D expressions #507

Closed
MartinNowak opened this Issue Feb 8, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@MartinNowak
Contributor

MartinNowak commented Feb 8, 2014

I tried to inline a style sheet using style!= import("style.css").
This doesn't work because the style tag content isn't treated as D expression and outputs
<style><!--!= import("style.css")--></style>.
As a workaround string interpolation does work (style #{import("style.css")}).
I've checked that behavior against Jade, Jade - Template Engine, they treat style tags like any other tag.

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Feb 8, 2014

Contributor

Ah, the workaround must be style !{import("style.css")} or the css file will have escaped newlines.

Contributor

MartinNowak commented Feb 8, 2014

Ah, the workaround must be style !{import("style.css")} or the css file will have escaped newlines.

s-ludwig added a commit that referenced this issue Feb 9, 2014

Handle "style" tag with inline content also correctly ("script" was a…
…lready fixed).

Supposedly fixes issue #507, but not yet verified.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 10, 2014

Member

Confirming this to be fixed.

Member

s-ludwig commented Feb 10, 2014

Confirming this to be fixed.

@s-ludwig s-ludwig closed this Feb 10, 2014

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Feb 10, 2014

Contributor

Thanks, should work for me.

Contributor

MartinNowak commented Feb 10, 2014

Thanks, should work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment