New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPServerRequest.fullURL crashes when host is missing #786

Closed
luismarques opened this Issue Aug 21, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@luismarques

luismarques commented Aug 21, 2014

The property HTTPServerRequest.fullURL does not work correctly with HTTP 1.0 (no Host header) or if you pass it an empty host header (e.g., wget --header="Host:"), causing the server to crash in the line url.host = url.host.split(":")[0];, due to url.host being null, the split result having 0 length, and therefore the [0] indexing generating a range violation error.

@s-ludwig s-ludwig closed this in 607f7cf Aug 21, 2014

@s-ludwig s-ludwig added the bug label Aug 21, 2014

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 21, 2014

Member

(not yet verified)

Member

s-ludwig commented Aug 21, 2014

(not yet verified)

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 21, 2014

Member

Successfully tested on Linux now.

Member

s-ludwig commented Aug 21, 2014

Successfully tested on Linux now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment