New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] @path doesn't check for placeholders #949

Closed
Geod24 opened this Issue Jan 3, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@Geod24
Contributor

Geod24 commented Jan 3, 2015

The following code:

@rootPath("/repos/")
interface IGithubPR {
  @path(":owner/:repo/pulls")
  GithubPR getPullRequests(string owner, string repo);
}

Is an easily made typo at this time of the day :)
In this specific case, it results in an assertion failure:
core.exception.AssertError@../../.dub/packages/vibe-d-master/source/vibe/inet/path.d(186): Trying to append absolute path.

The REST generator can and should detect it, and error accordingly.

s-ludwig added a commit that referenced this issue Mar 12, 2015

Merge pull request #1001 from Geod24/fix-949
[REST] Reorganize error handling + fix issue #949
@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Mar 15, 2015

Contributor

Fixed in #1001 (but I screwed up the title :-( )

Contributor

Geod24 commented Mar 15, 2015

Fixed in #1001 (but I screwed up the title :-( )

@Geod24 Geod24 closed this Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment