New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of block comments #1004

Merged
merged 1 commit into from Mar 9, 2015

Conversation

Projects
None yet
2 participants
@redstar
Contributor

redstar commented Mar 8, 2015

A block comment

body
  //
    Line 1
    Line 2

should be rendered as

<body>
    <!--
      Line 1
      Line 2
    -->
</body>

Currently, the block content is treated as normal template code.

This PR fixes the output behaviour.

Fix output of block comments
A block comment

    body
      //
        Line 1
        Line 2

should be rendered as

    <body>
        <!--
          Line 1
          Line 2
        -->
    </body>

Currently, the block content is treated as normal template code.

This PR fixes the output behaviour.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 9, 2015

Member

Thanks, you are right. When implementing this, my idea was to avoid accidentally leaking source code to the output, but I've never actually looked at what Jade does, and that makes a lot of sense, too.

Member

s-ludwig commented Mar 9, 2015

Thanks, you are right. When implementing this, my idea was to avoid accidentally leaking source code to the output, but I've never actually looked at what Jade does, and that makes a lot of sense, too.

s-ludwig added a commit that referenced this pull request Mar 9, 2015

@s-ludwig s-ludwig merged commit 4759dbb into vibe-d:master Mar 9, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@redstar redstar deleted the redstar:blockcomment branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment