New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plain text starting with < in Diet templates. #1007

Merged
merged 1 commit into from Mar 10, 2015

Conversation

Projects
None yet
2 participants
@redstar
Contributor

redstar commented Mar 9, 2015

This is the Jade way to emit conditional comments but works
with all plain text starting with <, too.

See http://jade-lang.com/reference/comments/.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 9, 2015

Member

Hm, interesting, did they remove the //if syntax? I'm pretty sure that it came from Jade when I implemented it. Anyway, supporting this shouldn't hurt! Can you add a short unit test around line 1455 to ensure that this stays functional?

Member

s-ludwig commented Mar 9, 2015

Hm, interesting, did they remove the //if syntax? I'm pretty sure that it came from Jade when I implemented it. Anyway, supporting this shouldn't hurt! Can you add a short unit test around line 1455 to ensure that this stays functional?

Implement plain text starting with < in Diet templates.
This is the Jade way to emit conditional comments but works
with all plain text starting with <, too.

See http://jade-lang.com/reference/comments/.
@redstar

This comment has been minimized.

Show comment
Hide comment
@redstar

redstar Mar 9, 2015

Contributor

Sure!

Contributor

redstar commented Mar 9, 2015

Sure!

@redstar

This comment has been minimized.

Show comment
Hide comment
@redstar

redstar Mar 9, 2015

Contributor

According to the Jade changelog, version 1.0.0 removed support for conditional comments.

Contributor

redstar commented Mar 9, 2015

According to the Jade changelog, version 1.0.0 removed support for conditional comments.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 10, 2015

Member

Okay, thanks! Definitely makes sense to try and stay compatible with the 1.0.0 spec.

Member

s-ludwig commented Mar 10, 2015

Okay, thanks! Definitely makes sense to try and stay compatible with the 1.0.0 spec.

s-ludwig added a commit that referenced this pull request Mar 10, 2015

Merge pull request #1007 from redstar/plaintext
Implement plain text starting with < in Diet templates.

@s-ludwig s-ludwig merged commit 46e8d01 into vibe-d:master Mar 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@redstar redstar deleted the redstar:plaintext branch Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment