New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation notice for index handling in vibe.web.rest #1010

Merged
merged 2 commits into from Mar 25, 2015

Conversation

Projects
None yet
2 participants
@Geod24
Contributor

Geod24 commented Mar 12, 2015

This had been deprecated in fe6a5de and so this message is there since July 2013 (and not relevant anymore). Time to remove it ?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 12, 2015

Member

Instead of removing just the deprecation message, the whole index special case should be removed. For that we'd need something like a disable_index_special_case = false parameter for extractHTTPMethodAndName, because unfortunately the vibe.web.web module still needs to support it (although it was never supposed to be supported there in the first place).

Member

s-ludwig commented Mar 12, 2015

Instead of removing just the deprecation message, the whole index special case should be removed. For that we'd need something like a disable_index_special_case = false parameter for extractHTTPMethodAndName, because unfortunately the vibe.web.web module still needs to support it (although it was never supposed to be supported there in the first place).

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Mar 12, 2015

Contributor

Since there was no other code, I though it was already removed. I'll take a look later this week then.

Contributor

Geod24 commented Mar 12, 2015

Since there was no other code, I though it was already removed. I'll take a look later this week then.

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Mar 25, 2015

Contributor

Updated (and added small cosmetic changes).

Contributor

Geod24 commented Mar 25, 2015

Updated (and added small cosmetic changes).

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 25, 2015

Member

There still seems to be a missing false template parameter at rest.d line 813 according to Travis.

Member

s-ludwig commented Mar 25, 2015

There still seems to be a missing false template parameter at rest.d line 813 according to Travis.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 25, 2015

Member

Nevermind. Your fix came in just in the second I commented.

Member

s-ludwig commented Mar 25, 2015

Nevermind. Your fix came in just in the second I commented.

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Mar 25, 2015

Contributor

Yup, and that means the unittest don't cover that line. Reminds me that I never checked the coverage on Vibe.
It should be fixed now (and tabs are in).

Contributor

Geod24 commented Mar 25, 2015

Yup, and that means the unittest don't cover that line. Reminds me that I never checked the coverage on Vibe.
It should be fixed now (and tabs are in).

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 Mar 25, 2015

Contributor

Green :)

Contributor

Geod24 commented Mar 25, 2015

Green :)

s-ludwig added a commit that referenced this pull request Mar 25, 2015

Merge pull request #1010 from Geod24/fix-deprecation-rest
Remove deprecation notice for index handling in vibe.web.rest

@s-ludwig s-ludwig merged commit d0c9db3 into vibe-d:master Mar 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Geod24 Geod24 deleted the Geod24:fix-deprecation-rest branch Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment