New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of hidden comments #1012

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
2 participants
@redstar
Contributor

redstar commented Mar 13, 2015

The hidden comment from the web site

//-title there is no title

is actually processed as

<//-title>there is no title<///-title>

because there is no whitespace between - and t. Jade treats //-title
as a hidden comment.

This PR fixes the parsing problem. I moved all the comment handling
code into one place, too.

Fix parsing of hidden comments
The hidden comment from the web site

    //-title there is no title

is actually processed as

    <//-title>there is no title<///-title>

because there is no whitespace between - and t. Jade treats //-title
as a hidden comment.

This PR fixes the parsing problem. I moved all the comment handling
code into one place, too.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 14, 2015

Member

Looks good, thanks!

Member

s-ludwig commented Mar 14, 2015

Looks good, thanks!

s-ludwig added a commit that referenced this pull request Mar 14, 2015

@s-ludwig s-ludwig merged commit 87e5fb0 into vibe-d:master Mar 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@redstar redstar deleted the redstar:commentparser branch Mar 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment