New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip() DigestAuth directives and make them case-insensitive. #1083

Merged
merged 1 commit into from May 1, 2015

Conversation

Projects
None yet
2 participants
@aka-demik
Contributor

aka-demik commented Apr 29, 2015

The current implementation of Digest authentication does not work in FireFox. He uses comma+space as a directives delimiter.
Plus added toLower () as in RFC 2617 said:

The realm directive (case-insensitive) is required for all authentication schemes that issue a challenge. The realm value (case-sensitive), in combination with the canonical...

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 1, 2015

Member

Thanks! I'll also change the if-list to a single switch statement.

Member

s-ludwig commented May 1, 2015

Thanks! I'll also change the if-list to a single switch statement.

s-ludwig added a commit that referenced this pull request May 1, 2015

Merge pull request #1083 from aka-demik/digestAuthFix
strip() DigestAuth directives and make them case-insensitive.

@s-ludwig s-ludwig merged commit 879a2c8 into vibe-d:master May 1, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@aka-demik aka-demik deleted the aka-demik:digestAuthFix branch May 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment