New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HTTPRouter #1106

Merged
merged 2 commits into from May 15, 2015

Conversation

Projects
None yet
2 participants
@Geod24
Contributor

Geod24 commented May 14, 2015

The removal notice has been around for more than a year (24 april 2014). It's time to stick a deprecate attribute on this. Based on #1104 to be green.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 15, 2015

Member

I thought about how to deprecate the interface (or rather deprecate using the interface as a base interface to URLRouter) without breaking code that relies on it (using alias this tricks and similar means). But I didn't find any that worked in the end (without issuing a deprecation message when building vibe.d itself). So unless we do find a way to make this happen, we can instead as well remove the interface altogether.

Member

s-ludwig commented May 15, 2015

I thought about how to deprecate the interface (or rather deprecate using the interface as a base interface to URLRouter) without breaking code that relies on it (using alias this tricks and similar means). But I didn't find any that worked in the end (without issuing a deprecation message when building vibe.d itself). So unless we do find a way to make this happen, we can instead as well remove the interface altogether.

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 May 15, 2015

Contributor

I would have went for a straight removal, because I doubt anyone use the interface itself.
Some people might use it in their signature, so maybe we could just provide an alias to avoid breaking signature, and just breaks everything that relied on it being an interface. How does the updated code sound ?

Contributor

Geod24 commented May 15, 2015

I would have went for a straight removal, because I doubt anyone use the interface itself.
Some people might use it in their signature, so maybe we could just provide an alias to avoid breaking signature, and just breaks everything that relied on it being an interface. How does the updated code sound ?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 15, 2015

Member

There could indeed be a few people deriving from HTTPRouter, because it was added by request back then. But I guess it should be few enough that the alias solution is a good alternative.

Member

s-ludwig commented May 15, 2015

There could indeed be a few people deriving from HTTPRouter, because it was added by request back then. But I guess it should be few enough that the alias solution is a good alternative.

s-ludwig added a commit that referenced this pull request May 15, 2015

@s-ludwig s-ludwig merged commit 8f4dbe8 into vibe-d:master May 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Geod24 Geod24 deleted the Geod24:remove-urlrouter-interface branch Jun 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment