New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encoding rework #1148

Merged
merged 1 commit into from Jun 22, 2015

Conversation

Projects
None yet
2 participants
@IgorStepanov
Contributor

IgorStepanov commented Jun 22, 2015

No description provided.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jun 22, 2015

Member

Thanks! Merging.

Member

s-ludwig commented Jun 22, 2015

Thanks! Merging.

s-ludwig added a commit that referenced this pull request Jun 22, 2015

@s-ludwig s-ludwig merged commit 9fcf224 into vibe-d:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IgorStepanov

This comment has been minimized.

Show comment
Hide comment
@IgorStepanov

IgorStepanov Jun 22, 2015

Contributor

@s-ludwig thanks! #1143 has been rebased. Please, comment it.

Contributor

IgorStepanov commented Jun 22, 2015

@s-ludwig thanks! #1143 has been rebased. Please, comment it.

@@ -187,7 +199,7 @@ struct URL {
str = str[0 .. qi];
} else m_queryString = null;
m_pathString = str;
m_pathString = urlEncode(str, "/");

This comment has been minimized.

@s-ludwig

s-ludwig Jul 4, 2015

Member

I didn't realize this during the review, but this causes m_pathString to be encoded twice when URL is constructed from a string. Fixed by 9ae8806.

@s-ludwig

s-ludwig Jul 4, 2015

Member

I didn't realize this during the review, but this causes m_pathString to be encoded twice when URL is constructed from a string. Fixed by 9ae8806.

s-ludwig added a commit that referenced this pull request Jul 4, 2015

Avoid overly strict URL encoding enforcement. See #1148.
The new version is actually a bit too lax in theory, but the most important point is to never reject valid strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment