New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong request time in access log when the connection is dropped #1157

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@marcioapm
Contributor

marcioapm commented Jun 26, 2015

No description provided.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jun 29, 2015

Member

I wonder if we don't have a larger issue here. Not calling finalize() not only means that the request time isn't properly recorded, but also that we potentially leak resources. Do you have an exact reproduction recipe for this?

Member

s-ludwig commented Jun 29, 2015

I wonder if we don't have a larger issue here. Not calling finalize() not only means that the request time isn't properly recorded, but also that we potentially leak resources. Do you have an exact reproduction recipe for this?

@marcioapm

This comment has been minimized.

Show comment
Hide comment
@marcioapm

marcioapm Jun 29, 2015

Contributor

I believe it's happening mostly when refreshing while loading.
If you have a route that takes slightly longer to serve, press refresh a few times, not letting it finish and it should reproduce.

Contributor

marcioapm commented Jun 29, 2015

I believe it's happening mostly when refreshing while loading.
If you have a route that takes slightly longer to serve, press refresh a few times, not letting it finish and it should reproduce.

@s-ludwig s-ludwig closed this in 4d4256f Jun 29, 2015

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jun 29, 2015

Member

Okay, I reproduced it and now finalize() is simply always called. I've added some checks to avoid additional log noise/exceptions.

Member

s-ludwig commented Jun 29, 2015

Okay, I reproduced it and now finalize() is simply always called. I've added some checks to avoid additional log noise/exceptions.

@marcioapm

This comment has been minimized.

Show comment
Hide comment
@marcioapm

marcioapm Jun 29, 2015

Contributor

Good stuff! Thanks! :)

Contributor

marcioapm commented Jun 29, 2015

Good stuff! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment