Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send binary with WebSocket class #118

Merged
merged 2 commits into from Oct 26, 2012

Conversation

Projects
None yet
2 participants
@kyubuns
Copy link
Contributor

commented Oct 26, 2012

#116
implement WebSocket.send(ubyte[] data) and WebSocket.send(string data)

@s-ludwig

This comment has been minimized.

Copy link

commented on adf2672 Oct 26, 2012

I'm not sure about the technical details(*), but wouldn't it make sense to have two overloads of send - one that takes a string and one a ubyte[]? The former would then send as Text and the latter as Binary.

(*) like are text messages UTF-8 encoded and is there any difference in transport between text and binary at all

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Oct 26, 2012

Thanks for taking the additional time!

s-ludwig added a commit that referenced this pull request Oct 26, 2012

@s-ludwig s-ludwig merged commit bbe5890 into vibe-d:master Oct 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.