New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of a 0 second timer, avoid processing them in a task #1204

Merged
merged 3 commits into from Sep 21, 2015

Conversation

Projects
None yet
2 participants
@etcimon
Contributor

etcimon commented Jul 31, 2015

This fixes the immediate return issue in waitForData for 0 second timers, amonst other problems.

I think a negative duration might be better suited for immediate timers, since the 0 second already has defined behavior in some cases, mostly because libevent seems to never set a timer (infinite duration)

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Aug 5, 2015

Contributor

Don't forget this patch for release, processTimers wasnt being run correctly

Contributor

etcimon commented Aug 5, 2015

Don't forget this patch for release, processTimers wasnt being run correctly

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 21, 2015

Contributor

Bump

Contributor

etcimon commented Sep 21, 2015

Bump

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 21, 2015

Contributor

Bump this too: #1247

Contributor

etcimon commented Sep 21, 2015

Bump this too: #1247

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 21, 2015

Member

Okay, looks good. Just that I unfortunately missed this before release anyway...

It needs a rebase, though (merge conflicts).

Member

s-ludwig commented Sep 21, 2015

Okay, looks good. Just that I unfortunately missed this before release anyway...

It needs a rebase, though (merge conflicts).

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 21, 2015

Contributor

It needs a rebase, though (merge conflicts).

Done

Contributor

etcimon commented Sep 21, 2015

It needs a rebase, though (merge conflicts).

Done

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 21, 2015

Member

Thanks!

Member

s-ludwig commented Sep 21, 2015

Thanks!

s-ludwig added a commit that referenced this pull request Sep 21, 2015

Merge pull request #1204 from etcimon/libasync-timers
Fix behavior of a 0 second timer, avoid processing them in a task

@s-ludwig s-ludwig merged commit 43f1b7e into vibe-d:master Sep 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment