New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-0.7.24] Fix runWorkerTaskH when called outside of a task. #1206

Merged
merged 6 commits into from Oct 11, 2015

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Aug 1, 2015

This fix has revealed some issues in the libev and libasync back ends and needs to be postponed to the next release.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Aug 1, 2015

Contributor

I tried to reproduce this but now I'm getting linker errors for libasync on windows.. might need one last patch

Contributor

etcimon commented Aug 1, 2015

I tried to reproduce this but now I'm getting linker errors for libasync on windows.. might need one last patch

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Aug 1, 2015

Contributor

Hm I tried fixing this and it's going to take a little time. I'll check back on it in a few months =)

Contributor

etcimon commented Aug 1, 2015

Hm I tried fixing this and it's going to take a little time. I'll check back on it in a few months =)

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 13, 2015

Member

Do you have a rough idea of what goes wrong/needs to be changed? I'd like to include this on master and either fix the failing drivers, or add assertions/skip tests for them.

Member

s-ludwig commented Sep 13, 2015

Do you have a rough idea of what goes wrong/needs to be changed? I'd like to include this on master and either fix the failing drivers, or add assertions/skip tests for them.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 13, 2015

Contributor

Last I checked I stopped at the thought that it's a runWorkerTaskH ambuiguity in the recursion (after fixing the driver error). I think it's that template parameter call causing issues the way they're nested through delegates.

Contributor

etcimon commented Sep 13, 2015

Last I checked I stopped at the thought that it's a runWorkerTaskH ambuiguity in the recursion (after fixing the driver error). I think it's that template parameter call causing issues the way they're nested through delegates.

s-ludwig added some commits Aug 1, 2015

Fix registration of ev_async in LibevManualEvent.
Needs to have a fixed address, so we use `new` now instead of directly storing in the AA.

Also removes some stdout noise.
Fix shutdown sequence.
The main thread used to remove itself from the thread list prior to waiting for the worker threads to shut down. This could cause the worker threads to think that they are in fact the main thread, because now they had the index 0. This change delays removing the main thread until all other threads have shut down.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Oct 11, 2015

Member

Tests finally pass now after fixing the libev driver. The libasync issue seems to have gone, too.

(the failure is just due to a Travis internal issue)

Member

s-ludwig commented Oct 11, 2015

Tests finally pass now after fixing the libev driver. The libasync issue seems to have gone, too.

(the failure is just due to a Travis internal issue)

s-ludwig added a commit that referenced this pull request Oct 11, 2015

Merge pull request #1206 from rejectedsoftware/fix-workertask
[post-0.7.24] Fix runWorkerTaskH when called outside of a task.

@s-ludwig s-ludwig merged commit f74f4e5 into master Oct 11, 2015

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the fix-workertask branch Oct 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment