New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libasync (linux) - Make sure TCP write ready events always occur #1247

Merged
merged 1 commit into from Oct 29, 2015

Conversation

Projects
None yet
2 participants
@etcimon
Contributor

etcimon commented Sep 4, 2015

No description provided.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 11, 2015

Contributor

This is a pretty bad bug actually, the connection freezes when write blocks. Should be merged urgently.

Contributor

etcimon commented Sep 11, 2015

This is a pretty bad bug actually, the connection freezes when write blocks. Should be merged urgently.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Oct 28, 2015

Contributor

Tested in production as well

Contributor

etcimon commented Oct 28, 2015

Tested in production as well

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Oct 28, 2015

Member

I didn't merge this earlier because I didn't understand why a write operation would depend on a "read ready" event. Do you have any further insights on this? Anyway, this is safe to merge, so I'll include it in the release.

Member

s-ludwig commented Oct 28, 2015

I didn't merge this earlier because I didn't understand why a write operation would depend on a "read ready" event. Do you have any further insights on this? Anyway, this is safe to merge, so I'll include it in the release.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Oct 28, 2015

Contributor

I also have an issue understanding why I was blocking on write and receiving only a read event

Contributor

etcimon commented Oct 28, 2015

I also have an issue understanding why I was blocking on write and receiving only a read event

s-ludwig added a commit that referenced this pull request Oct 29, 2015

Merge pull request #1247 from etcimon/patch-21
Libasync (linux) - Make sure TCP write ready events always occur

@s-ludwig s-ludwig merged commit ba16086 into vibe-d:master Oct 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment