New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit event loop in libasync using a signal #1349

Merged
merged 3 commits into from Dec 9, 2015

Conversation

Projects
None yet
2 participants
@etcimon
Contributor

etcimon commented Dec 8, 2015

No description provided.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 9, 2015

Member

I've taken a closer look and the issue is with the unit test in vibe.core.sync, line 303 ff.

t1 hangs in sleep(20.msecs); indefinitely, so that t1.join() never returns either.

Member

s-ludwig commented Dec 9, 2015

I've taken a closer look and the issue is with the unit test in vibe.core.sync, line 303 ff.

t1 hangs in sleep(20.msecs); indefinitely, so that t1.join() never returns either.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Dec 9, 2015

Contributor

Yes, the timer isn't being rescheduled because of a mistake I made in the driver. I'm testing it some more submitting a pull request.

Contributor

etcimon commented Dec 9, 2015

Yes, the timer isn't being rescheduled because of a mistake I made in the driver. I'm testing it some more submitting a pull request.

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Dec 9, 2015

Contributor

Seems like it was a pretty serious issue

Contributor

etcimon commented Dec 9, 2015

Seems like it was a pretty serious issue

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 9, 2015

Member

Looks nasty. Good to have this resolved!

Member

s-ludwig commented Dec 9, 2015

Looks nasty. Good to have this resolved!

s-ludwig added a commit that referenced this pull request Dec 9, 2015

Merge pull request #1349 from etcimon/patch-30
Exit event loop in libasync using a signal

@s-ludwig s-ludwig merged commit f2fae7a into vibe-d:master Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment