New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable botan usage with VibeNoSSL #1444

Merged
merged 1 commit into from Aug 7, 2016

Conversation

Projects
None yet
3 participants
@MartinNowak
Contributor

MartinNowak commented Mar 1, 2016

No description provided.

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Mar 1, 2016

Contributor

It seems some bug in dub is still causing optional dependencies to be downloaded and build.
I though I can select optional dependencies through my dub.selections.json.

Contributor

MartinNowak commented Mar 1, 2016

It seems some bug in dub is still causing optional dependencies to be downloaded and build.
I though I can select optional dependencies through my dub.selections.json.

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Mar 1, 2016

Contributor

That's apparently a bug in the development version of dub.

Contributor

MartinNowak commented Mar 1, 2016

That's apparently a bug in the development version of dub.

@dariusc93

This comment has been minimized.

Show comment
Hide comment
@dariusc93

dariusc93 Mar 9, 2016

Contributor

+1

Contributor

dariusc93 commented Mar 9, 2016

+1

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 9, 2016

Member

I'll have a look at the DUB master issue. Since 0.9.24 handles optional dependencies in a totally unacceptable way (at least for the default build path that is affected in this case), this change will have to be postponed until 0.9.25 is reasonably widespread.

One thing that should be changed, though, is to add "default": true for openssl, so that the default build still supports TLS.

Member

s-ludwig commented Mar 9, 2016

I'll have a look at the DUB master issue. Since 0.9.24 handles optional dependencies in a totally unacceptable way (at least for the default build path that is affected in this case), this change will have to be postponed until 0.9.25 is reasonably widespread.

One thing that should be changed, though, is to add "default": true for openssl, so that the default build still supports TLS.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 9, 2016

Member

DUB master works fine for me. I initially thought I had the same problem, but it turned out that it simply still selected a previous version of vibe.d, thus still having openssl as non-optional.

Member

s-ludwig commented Mar 9, 2016

DUB master works fine for me. I initially thought I had the same problem, but it turned out that it simply still selected a previous version of vibe.d, thus still having openssl as non-optional.

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Mar 9, 2016

Contributor

Done, we really should release a new dub version soon, the last release is already 6 month old, and master has heavily diverged since then.

Contributor

MartinNowak commented Mar 9, 2016

Done, we really should release a new dub version soon, the last release is already 6 month old, and master has heavily diverged since then.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 9, 2016

Member

Yep, I had too little time recently to make progress on issues that I initially wanted to get into 0.9.25. However, since that is probably going to stay true for another few weeks, we can just as well make another release in-between. Would be good to get dlang/dub#762 merged and I'll have to try to remember the issues I had with the current dub describe --data=....

Member

s-ludwig commented Mar 9, 2016

Yep, I had too little time recently to make progress on issues that I initially wanted to get into 0.9.25. However, since that is probably going to stay true for another few weeks, we can just as well make another release in-between. Would be good to get dlang/dub#762 merged and I'll have to try to remember the issues I had with the current dub describe --data=....

@MartinNowak MartinNowak changed the title from make openssl an optional dependency to disable botan usage with VibeNoSSL Aug 5, 2016

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Aug 5, 2016

Contributor

Reduced the sope of the PR to just the botan change.
Making openssl optional was already done while switching to SDL.

Contributor

MartinNowak commented Aug 5, 2016

Reduced the sope of the PR to just the botan change.
Making openssl optional was already done while switching to SDL.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 7, 2016

Member

Okay, should be good to go with 1.0.0 out now.

Member

s-ludwig commented Aug 7, 2016

Okay, should be good to go with 1.0.0 out now.

@s-ludwig s-ludwig merged commit 907a826 into vibe-d:master Aug 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MartinNowak MartinNowak deleted the MartinNowak:optional_openssl branch Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment