New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed writeJsonBody not to always overwrite statusCode to 200 #1488

Merged
merged 2 commits into from May 18, 2016

Conversation

Projects
None yet
2 participants
@IrenejMarc
Contributor

IrenejMarc commented May 7, 2016

It was impossible to set the status code of any RestInterface functions, even through @after because it always got overwritten by writeJsonBody which defaulted to 200

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 18, 2016

Member

Can you move the doc comment to the first overload and put a /// ditto to the second one? Otherwise LGTM.

Member

s-ludwig commented May 18, 2016

Can you move the doc comment to the first overload and put a /// ditto to the second one? Otherwise LGTM.

@IrenejMarc

This comment has been minimized.

Show comment
Hide comment
@IrenejMarc

IrenejMarc May 18, 2016

Contributor

All done. My bad.

Contributor

IrenejMarc commented May 18, 2016

All done. My bad.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 18, 2016

Member

Okay, thanks!

Member

s-ludwig commented May 18, 2016

Okay, thanks!

@s-ludwig s-ludwig merged commit e61f2c6 into vibe-d:master May 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment