New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vibe.inet.urltransfer.download leaving stale sockets around #1532

Merged
merged 2 commits into from Jul 17, 2016

Conversation

Projects
None yet
2 participants
@Yoplitein
Contributor

Yoplitein commented Jul 17, 2016

No description provided.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 17, 2016

Member

Good catch, I never used download for anything serious (just requestHTTP directly) and didn't notice this. The only thing is that like this it would mean that keep-alive connections won't work anymore for the case where a custom HTTPClient is passed to download - something like a bool is_custom_client = client !is null; flag is needed.

Member

s-ludwig commented Jul 17, 2016

Good catch, I never used download for anything serious (just requestHTTP directly) and didn't notice this. The only thing is that like this it would mean that keep-alive connections won't work anymore for the case where a custom HTTPClient is passed to download - something like a bool is_custom_client = client !is null; flag is needed.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 17, 2016

Member

Okay, thanks!

Member

s-ludwig commented Jul 17, 2016

Okay, thanks!

@s-ludwig s-ludwig merged commit f9de27d into vibe-d:master Jul 17, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment