New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionPool's LocalTaskSemaphore Intermittent Infinite Wait Bug #1563

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
2 participants
@etcimon
Contributor

etcimon commented Sep 16, 2016

When the semaphore reached the lock limit, tasks can compete for a lock but the waiter sometimes ended up having its lock snatched. This fixes the issue by freeing the lock only if no waiter was called.

Fix issue where semaphore lock could get snatched and task would end …
…up waiting infinitely.

Dont check for availability

Locks may be consumed if wait is interruptible here

Fix emitcount
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 20, 2016

Member

LGTM!

Member

s-ludwig commented Sep 20, 2016

LGTM!

@s-ludwig s-ludwig merged commit c6bea84 into vibe-d:master Sep 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment