New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization support for std.typecons.Typedef!T. #1617

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
3 participants
@s-ludwig
Member

s-ludwig commented Nov 10, 2016

No description provided.

@DBankov

This change makes a lot of sense to me because I considered it myself while trying to solve a problem which eventually resulted in #1662.

The change looks good to me and I'd only suggest to have Typedefs with and without a cookie in the unit test and maybe also use a struct for one of the Typedefs.

@IrenejMarc

This comment has been minimized.

Show comment
Hide comment
@IrenejMarc

IrenejMarc May 12, 2017

Contributor

Any news on this?

Contributor

IrenejMarc commented May 12, 2017

Any news on this?

@s-ludwig s-ludwig removed the needs review label May 12, 2017

@s-ludwig s-ludwig merged commit 5b0c4d6 into master May 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 12, 2017

Member

Didn't notice that this was still sitting here...

Member

s-ludwig commented May 12, 2017

Didn't notice that this was still sitting here...

@s-ludwig s-ludwig deleted the typedef_serialization branch May 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment