New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SCRAM-SHA1 authentication method for mongo #1632

Merged
merged 2 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@ngurrola
Contributor

ngurrola commented Nov 25, 2016

The default is still MONGO-CR, even for server versions 3.0+ to maintain backwards compatibility. It can be switched by adding "authMechanism=SCRAM-SHA-1" to the connection query string.

Show outdated Hide outdated mongodb/vibe/db/mongo/sasl.d Outdated
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 27, 2016

Member

Really great to finally have this! I never had the time (and need) to implement it, even though it's a rather important feature.

Member

s-ludwig commented Nov 27, 2016

Really great to finally have this! I never had the time (and need) to implement it, even though it's a rather important feature.

Added code review changes
+ ScramState struct is now package instead of public
+ MongoClientSettings now uses MongoAuthMechanism enum for the authMechanism to better detect invalid mechanisms
@ngurrola

This comment has been minimized.

Show comment
Hide comment
@ngurrola

ngurrola Nov 27, 2016

Contributor

I added those changes as requested.

Contributor

ngurrola commented Nov 27, 2016

I added those changes as requested.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 28, 2016

Member

Looks good to merge. Thanks a lot!

Member

s-ludwig commented Nov 28, 2016

Looks good to merge. Thanks a lot!

@s-ludwig s-ludwig merged commit cc3c993 into vibe-d:master Nov 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

s-ludwig added a commit that referenced this pull request Dec 19, 2016

Merge pull request #1632 from ngurrola/mongo_scram
Implemented SCRAM-SHA1 authentication method for MongoDB. Fixes #1243. Fixes #1557.

s-ludwig added a commit that referenced this pull request Dec 21, 2016

Revert "Merge pull request #1632 from ngurrola/mongo_scram"
This reverts commit 19acf2a.

The goal is to keep 0.7.31 working with DMD 2.068.2.

@ngurrola ngurrola deleted the ngurrola:mongo_scram branch Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment