New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate XHR error to on_error in JS RestInterface #1645

Merged
merged 1 commit into from Dec 26, 2016

Conversation

Projects
None yet
2 participants
@Timoses
Contributor

Timoses commented Dec 26, 2016

Allow using the on_error function also when the XHR request fails completely (e.g. when the host is not available).
This is useful when needing feedback on whether or not the XHR request was successful or not.

If there's anything I can improve, please let me know!

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 26, 2016

Member

This was definitely missing. Thanks!

Member

s-ludwig commented Dec 26, 2016

This was definitely missing. Thanks!

@s-ludwig s-ludwig merged commit b0f29de into vibe-d:master Dec 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Timoses

This comment has been minimized.

Show comment
Hide comment
@Timoses

Timoses Dec 26, 2016

Contributor

So sorry, made a mistake using \n within backticks.
Pushed corrected commit:
Timoses@195cce9

Contributor

Timoses commented Dec 26, 2016

So sorry, made a mistake using \n within backticks.
Pushed corrected commit:
Timoses@195cce9

s-ludwig added a commit that referenced this pull request Jan 31, 2017

Merge pull request #1645 from Timoses/xhronerror
Propagate XHR error to on_error in JS RestInterface
(cherry picked from commit b0f29de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment