New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and further error handling capability #1646

Merged
merged 2 commits into from Dec 27, 2016

Conversation

Projects
None yet
2 participants
@Timoses
Contributor

Timoses commented Dec 26, 2016

Sorry again for previous mishap (#1645).

This one also allows to always receive an error when the server responds with an error (in case could not update, etc...).

This time it's tested..

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 26, 2016

Member

Thanks, that was easy to miss. I should really start to use the JS generator in practice and ideally there should be an automated test, too., but I need to look into which headless browser engine is best to use for Travis CI.

Member

s-ludwig commented Dec 26, 2016

Thanks, that was easy to miss. I should really start to use the JS generator in practice and ideally there should be an automated test, too., but I need to look into which headless browser engine is best to use for Travis CI.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 26, 2016

Member

The tests that currently check for the existence of "onload =" need to be adjusted (should probably check for existence of "on_result(" instead.

Member

s-ludwig commented Dec 26, 2016

The tests that currently check for the existence of "onload =" need to be adjusted (should probably check for existence of "on_result(" instead.

@Timoses

This comment has been minimized.

Show comment
Hide comment
@Timoses

Timoses Dec 26, 2016

Contributor

The tests that currently check for the existence of "onload =" need to be adjusted (should probably check for existence of "on_result(" instead.

Oh yes, I didn't think of checking.
Updated!🎄

Contributor

Timoses commented Dec 26, 2016

The tests that currently check for the existence of "onload =" need to be adjusted (should probably check for existence of "on_result(" instead.

Oh yes, I didn't think of checking.
Updated!🎄

@s-ludwig s-ludwig merged commit eec68c0 into vibe-d:master Dec 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment