New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for named tuple de/serialization as associative array #1662

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@DBankov
Contributor

DBankov commented Jan 23, 2017

This is an initial proposal for named tuple de/serialization support as associative arrays. Also part of this change is the deserialization support for the existing tuple serialization as standard arrays.

@DBankov

This comment has been minimized.

Show comment
Hide comment
@DBankov

DBankov Jan 27, 2017

Contributor

After looking at the contribution recommendations it seems that it may be better to split this PR in two. One with the Tuple deserialization support (from array) and another with the named tuple to/from associative array support.

Please let me know if the above would be better from reviewers' point of view.

Contributor

DBankov commented Jan 27, 2017

After looking at the contribution recommendations it seems that it may be better to split this PR in two. One with the Tuple deserialization support (from array) and another with the named tuple to/from associative array support.

Please let me know if the above would be better from reviewers' point of view.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jun 29, 2017

Member

Looks like this conflicted with the just merged tuple serialization PR. The change set otherwise looks ready to pull.

Member

s-ludwig commented Jun 29, 2017

Looks like this conflicted with the just merged tuple serialization PR. The change set otherwise looks ready to pull.

@DBankov

This comment has been minimized.

Show comment
Hide comment
@DBankov

DBankov Jul 3, 2017

Contributor

I'm sorry for the delay. I'll rebase ASAP.

Contributor

DBankov commented Jul 3, 2017

I'm sorry for the delay. I'll rebase ASAP.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 5, 2017

Member

Thanks! Merging.

Member

s-ludwig commented Jul 5, 2017

Thanks! Merging.

@s-ludwig s-ludwig merged commit 5d9d8e6 into vibe-d:master Jul 5, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 0437d5d...24f2940
Details
codecov/project 37.05% remains the same compared to 0437d5d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DBankov

This comment has been minimized.

Show comment
Hide comment
@DBankov

DBankov Jul 11, 2017

Contributor

Thanks a lot for merging this PR! :)

Contributor

DBankov commented Jul 11, 2017

Thanks a lot for merging this PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment