New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkBasicAuth function. #1687

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Feb 19, 2017

Separates the authorization test from authorization enforcement.

Fixes #1449.

Add checkBasicAuth function. Fixes #1449.
Separates the authorization test from auhtorization enforcement.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 20, 2017

Member

@denizzzka: Is checkBasicAuth sufficient for your use case, or is more control necessary?

Member

s-ludwig commented Feb 20, 2017

@denizzzka: Is checkBasicAuth sufficient for your use case, or is more control necessary?

@denizzzka

This comment has been minimized.

Show comment
Hide comment
@denizzzka

denizzzka Feb 21, 2017

Contributor

@s-ludwig checkBasicAuth exactly what is needed. Thanks!

(I am changed my code with checkBasicAuth, but can't run my integration tests because something changed in vibe.d: #1688.)

Contributor

denizzzka commented Feb 21, 2017

@s-ludwig checkBasicAuth exactly what is needed. Thanks!

(I am changed my code with checkBasicAuth, but can't run my integration tests because something changed in vibe.d: #1688.)

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 21, 2017

Member

Okay, I think it should be safe to still merge this into 0.8.0.

Regarding const/in, I don't want to shut the door for more lazy evaluation and reference counting, which is why the HTTPServerRe* values are always passed in plain form.

Member

s-ludwig commented Feb 21, 2017

Okay, I think it should be safe to still merge this into 0.8.0.

Regarding const/in, I don't want to shut the door for more lazy evaluation and reference counting, which is why the HTTPServerRe* values are always passed in plain form.

@s-ludwig s-ludwig merged commit 1faa9db into master Feb 21, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the issue1449-basic-auth-separate branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment