New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fix to REST bool query parameters #1712

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Projects
None yet
2 participants
@tchaloupka
Contributor

tchaloupka commented Mar 15, 2017

Just a simple fix to REST handler when bool query parameter is used. Not all clients generates expected "true" so it should be case insensitive.
Also sending 0 or 1 is pretty common.

Simple fix to REST bool query parameters
Just a simple fix to REST handler when bool query parameter is used. Not all clients generates expected "true" so it should be case insensitive.
Also sending 0 or 1 is pretty common.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 25, 2017

Member

Going to trust that Travis would pass if it weren't for the MongoDB compile error. The change looks good.

Member

s-ludwig commented Mar 25, 2017

Going to trust that Travis would pass if it weren't for the MongoDB compile error. The change looks good.

@s-ludwig s-ludwig merged commit bd5c994 into vibe-d:master Mar 25, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@tchaloupka tchaloupka deleted the tchaloupka:fix_bool branch Apr 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment