New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "before" annotations on REST interface classes. #1754

Merged
merged 2 commits into from May 7, 2017

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented May 4, 2017

Fixes #1753.

@Geod24

This comment has been minimized.

Show comment
Hide comment
@Geod24

Geod24 May 5, 2017

Contributor

Shouldn't @before on interface be discouraged ? The problem is that it describes server-only behavior so it can easily make the interface unusable for client generation (e.g. if the @before function have dependency on the DB, it drags it into the client as well).

Contributor

Geod24 commented May 5, 2017

Shouldn't @before on interface be discouraged ? The problem is that it describes server-only behavior so it can easily make the interface unusable for client generation (e.g. if the @before function have dependency on the DB, it drags it into the client as well).

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 6, 2017

Member

Definitely should be discouraged in their current form. The problem is that only those on the interface seem to have worked for a while now and I didn't notice when that became the case (don't use them anywhere anymore, AFAIR). So I'd let them go through a full deprecation cycle (doc -> warn -> error) to make sure they only appear on the class (and maybe any base class).

Member

s-ludwig commented May 6, 2017

Definitely should be discouraged in their current form. The problem is that only those on the interface seem to have worked for a while now and I didn't notice when that became the case (don't use them anywhere anymore, AFAIR). So I'd let them go through a full deprecation cycle (doc -> warn -> error) to make sure they only appear on the class (and maybe any base class).

s-ludwig added some commits May 4, 2017

@s-ludwig s-ludwig merged commit d2ec9d1 into master May 7, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the issue_1753_before_on_class branch May 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment