New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got vibe to compile against openssl 1.1.0 #1759

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@burner
Contributor

burner commented May 12, 2017

just a crude hack, but I think nothing is fundamentally wrong with it.

#1758

@burner

This comment has been minimized.

Show comment
Hide comment
@burner

burner May 12, 2017

Contributor

is there any way to see the openssl version

Contributor

burner commented May 12, 2017

is there any way to see the openssl version

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig May 12, 2017

Member

There is OpenSSL_version_num() - hopefully available on all involved versions.

Member

s-ludwig commented May 12, 2017

There is OpenSSL_version_num() - hopefully available on all involved versions.

@burner

This comment has been minimized.

Show comment
Hide comment
@burner

burner May 12, 2017

Contributor

I meant at link time. The tests seem to fail to link.

Contributor

burner commented May 12, 2017

I meant at link time. The tests seem to fail to link.

@burner

This comment has been minimized.

Show comment
Hide comment
@burner

burner May 27, 2017

Contributor

libressl looks like an alternative, has anyone had a look at that one yet?
they wrote a new tls library (tls.h) https://github.com/daniloegea/libressl-tls-api-examples shows an example

Contributor

burner commented May 27, 2017

libressl looks like an alternative, has anyone had a look at that one yet?
they wrote a new tls library (tls.h) https://github.com/daniloegea/libressl-tls-api-examples shows an example

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Jul 10, 2017

Contributor

I meant at link time. The tests seem to fail to link.

@burner: if you want to build a hack on top of a hack, you could use a preBuildsCommands and utilize the output of:

readelf -d /usr/lib/libssl.so | grep SONAME | sed -E 's/.*libssl[.]so[.](.*)].*/\1/'

e.g. by storing it in a gitignored D file

Contributor

wilzbach commented Jul 10, 2017

I meant at link time. The tests seem to fail to link.

@burner: if you want to build a hack on top of a hack, you could use a preBuildsCommands and utilize the output of:

readelf -d /usr/lib/libssl.so | grep SONAME | sed -E 's/.*libssl[.]so[.](.*)].*/\1/'

e.g. by storing it in a gitignored D file

@burner

This comment has been minimized.

Show comment
Hide comment
@burner

burner Jul 11, 2017

Contributor

@wilzbach thanks I will try that

Contributor

burner commented Jul 11, 2017

@wilzbach thanks I will try that

@s-ludwig s-ludwig closed this in 44ee1ad Aug 12, 2017

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 12, 2017

Member

I've pulled this now and embedded it into a version (VibeUseOpenSSL11) until a better option supported by DUB is available.

Member

s-ludwig commented Aug 12, 2017

I've pulled this now and embedded it into a version (VibeUseOpenSSL11) until a better option supported by DUB is available.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 12, 2017

Member

Maybe this can be solved in a proper way by extending the libs field to support version specifications or similar. The actual version could also be reported through a mechanism analog to dlang/dub#6.

BTW, @burner thanks a lot for having done the fiddling to get this working!

Member

s-ludwig commented Aug 12, 2017

Maybe this can be solved in a proper way by extending the libs field to support version specifications or similar. The actual version could also be reported through a mechanism analog to dlang/dub#6.

BTW, @burner thanks a lot for having done the fiddling to get this working!

@burner

This comment has been minimized.

Show comment
Hide comment
@burner

burner Aug 12, 2017

Contributor

@s-ludwig nice thanks

Contributor

burner commented Aug 12, 2017

@s-ludwig nice thanks

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Aug 14, 2017

Contributor

Maybe this can be solved in a proper way by extending the libs field to support version specifications or similar. The actual version could also be reported through a mechanism analog to dlang/dub#6.

BTW, @burner thanks a lot for having done the fiddling to get this working!

One supported way would be to let people choose different openssl dub versions, e.g. 1.1.5+1.0.2j or 2.0.1+1.1.0f. Unfortunately this is not automatic.
The libs field already does support versioned libraries, see the workaround in #1748 (comment). Most ld versions do support this syntax by now.

Contributor

MartinNowak commented Aug 14, 2017

Maybe this can be solved in a proper way by extending the libs field to support version specifications or similar. The actual version could also be reported through a mechanism analog to dlang/dub#6.

BTW, @burner thanks a lot for having done the fiddling to get this working!

One supported way would be to let people choose different openssl dub versions, e.g. 1.1.5+1.0.2j or 2.0.1+1.1.0f. Unfortunately this is not automatic.
The libs field already does support versioned libraries, see the workaround in #1748 (comment). Most ld versions do support this syntax by now.

@wilzbach

This comment has been minimized.

Show comment
Hide comment
@wilzbach

wilzbach Aug 14, 2017

Contributor

Why not list the openssl library dynamically?
Dlang-requests does this: ikod/dlang-requests#45 (comment)

Contributor

wilzbach commented Aug 14, 2017

Why not list the openssl library dynamically?
Dlang-requests does this: ikod/dlang-requests#45 (comment)

s-ludwig added a commit that referenced this pull request Mar 18, 2018

s-ludwig added a commit that referenced this pull request Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment